Skip to content

gh-132176: Fix crash on type() when tuple subclass passed as bases #132212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

gh-132176: Fix crash on type() when tuple subclass passed as bases #132212

merged 4 commits into from
Apr 15, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 7, 2025 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from markshannon as a code owner April 7, 2025 09:51
@bedevere-app bedevere-app bot mentioned this pull request Apr 7, 2025
Closed
vstinner
vstinner reviewed Apr 15, 2025
View reviewed changes
sobolevn
sobolevn commented Apr 15, 2025
View reviewed changes
@sobolevn @vstinner
Update Lib/test/test_types.py
b4b7f12 
Co-authored-by: Victor Stinner <[email protected]>
vstinner
vstinner approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn
Copy link
Member Author

Thank you, @vstinner for your help!

@sobolevn sobolevn added the needs backport to 3.13 bugs and security fixes label Apr 15, 2025
@sobolevn sobolevn merged commit b6c552f into python:main Apr 15, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 15, 2025
@sobolevn @vstinner @miss-islington
pythongh-132176: Fix crash on type() when tuple subclass passed a…
6675795 
…s `bases` (pythonGH-132212)

(cherry picked from commit b6c552f)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 15, 2025

GH-132548 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 15, 2025
sobolevn added a commit that referenced this pull request Apr 15, 2025
@miss-islington @sobolevn @vstinner
[3.13] gh-132176: Fix crash on type() when tuple subclass passed …
6d48194 
…as `bases` (GH-132212) (#132548)

gh-132176: Fix crash on `type()` when `tuple` subclass passed as `bases` (GH-132212)
(cherry picked from commit b6c552f)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@vstinner
Copy link
Member

aarch64 Fedora Stable LTO + PGO 3.x and aarch64 Fedora Stable LTO 3.13 failed because their disk is full, see: #132553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@corona10 corona10 Awaiting requested review from corona10

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @vstinner